gh-157290: Add support for %Nf to datetime.str{f,p}time() - #157704
Open
StanFromIreland wants to merge 3 commits into
Open
StanFromIreland wants to merge 3 commits into
StanFromIreland wants to merge 3 commits into
Conversation
Co-authored-by: Karoline Pauls <code@karolinepauls.com>
Documentation build overview
46 files changed ·
|
vstinner
reviewed
Sep 30, 2026
Co-authored-by: Victor Stinner <vstinner@python.org>
Member
Author
|
Thanks Victor, I applied your suggestions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a slightly simpler approach than the one proposed in #157291. It drops the per-N replacement cache (the existing %f string is sliced instead. I haven't benchmarked it, but I doubt it saves much given it's just an
sprintf) and the newValueErrorfor%7fto%9f, which is inconsistent, since%10fand%.3f(which Rust'schronosupports) still fall through. It also tidies the tests a little.